chore: Clean up out-of-date comments for aggregate refactor - #25007
Merged
Conversation
github-actions
Bot
added
documentation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25007 +/- ##
==========================================
+ Coverage 81.69% 81.74% +0.04%
==========================================
Files 1127 1128 +1
Lines 415386 416762 +1376
Branches 415386 416762 +1376
==========================================
+ Hits 339360 340685 +1325
+ Misses 56091 56006 -85
- Partials 19935 20071 +136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
approved these changes
Sep 8, 2026
| /// their preconditions are satisfied. When set to false, grouped | ||
| /// aggregation falls back to `GroupedHashAggregateStream`. This option | ||
| /// will be removed after the migration is finished. | ||
| /// The split is complete, so the default `true` plans every grouped |
Contributor
There was a problem hiding this comment.
I recommend focusing this more on the end user behavior -- something like
/// When set to false, falls back to the pre 55.0.0 aggregation code.
/// The fallback is intended as a workaround in case of bugs and
/// will be deleted after the 56.0.0 release together with this option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #25006
Rationale for this change
The refactor has been completed functionally, this PR updates the comments to keep things in sync.
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?